Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(bigtable): document connection pooling model #9583

Merged
merged 2 commits into from
Jul 28, 2022
Merged

doc(bigtable): document connection pooling model #9583

merged 2 commits into from
Jul 28, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jul 28, 2022 •
edited by coryan
Loading

Fixes #1553

This change is Reviewable

@dbolduc dbolduc requested a review from a team as a code owner July 28, 2022 17:41
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jul 28, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 22eb3df1873c628a793a7e609e7dd26a2f5095c2

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #9583 (2c79699) into main (215a1f3) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9583      +/-   ##
==========================================
- Coverage   94.36%   94.36%   -0.01%     
==========================================
  Files        1491     1491              
  Lines      137590   137590              
==========================================
- Hits       129840   129838       -2     
- Misses       7750     7752       +2
Impacted Files Coverage Δ
google/cloud/bigtable/data_connection.h 100.00% <ø> (ø)
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 84.21% <0.00%> (-0.66%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 96.59% <0.00%> (-0.57%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (ø)
google/cloud/pubsub/samples/samples.cc 90.77% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215a1f3...2c79699. Read the comment docs.

coryan
coryan approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the active voice, e.g. "If this option is not set, the class creates between 1 and 64 channels."

Also consider being explicit about what is subject to change, e.g., "... between 1 and 64 channels. The specific algorithm and number of channels is an implementation detail, and subject to change without notice."

@dbolduc dbolduc enabled auto-merge (squash) July 28, 2022 19:15
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 2c796991a6acd2216b994f90016889f543f48bd3

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc merged commit 7735b70 into googleapis:main Jul 28, 2022
@dbolduc dbolduc deleted the bigtable-data-connection-pool-model branch July 28, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the connection pooling model in the Bigtable library.
3 participants
@dbolduc @google-cloud-cpp-bot @coryan